Skip to content

feat: Add cloudwatch lambda event support to Parser utility #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 4, 2020
Merged

feat: Add cloudwatch lambda event support to Parser utility #231

merged 6 commits into from
Dec 4, 2020

Conversation

ran-isenberg
Copy link
Contributor

see #230

heitorlessa
heitorlessa suggested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Minor suggestions and one question on zlib header/trailer size param.

As with other PRs, I'll write the docs afterwards ;)

@heitorlessa heitorlessa added area/utilities feature New feature or functionality labels Dec 1, 2020
@codecov-io
Copy link

codecov-io commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #231 (a09f434) into develop (415bfc6) will decrease coverage by 0.07%.
The diff coverage is 96.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #231      +/-   ##
===========================================
- Coverage    99.88%   99.81%   -0.08%     
===========================================
  Files           71       73       +2     
  Lines         2615     2665      +50     
  Branches       109      110       +1     
===========================================
+ Hits          2612     2660      +48     
- Misses           3        5       +2
Impacted Files Coverage Δ
...a_powertools/utilities/parser/models/cloudwatch.py 93.93% <93.93%> (ø)
..._powertools/utilities/parser/envelopes/__init__.py 100.00% <100.00%> (ø)
...owertools/utilities/parser/envelopes/cloudwatch.py 100.00% <100.00%> (ø)
...bda_powertools/utilities/parser/models/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415bfc6...a09f434. Read the comment docs.

@heitorlessa
docs: add CW Logs as a supported model
647f903
@heitorlessa
Merge branch 'develop' into cloudwatch
a09f434 
* develop:
  docs: add Alb as a supported model
  docs: shadow sidebar to remain expanded
  feat: Add alb lambda event support to Parser utility #228
@heitorlessa
fix: cloudwatch logs envelope typo
d07db54
@heitorlessa
docs: add CW Logs as a supported envelope
ccd2a00
heitorlessa
heitorlessa approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs added and envelope type fixed - Merging

@heitorlessa heitorlessa merged commit 88bd2e0 into aws-powertools:develop Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorlessa heitorlessa heitorlessa approved these changes

Assignees
No one assigned
Labels
feature New feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-isenberg @codecov-io @heitorlessa